feat(oppijanumero): change runCatching to try-catch

and add key-values to logging indicate whether the parsing was succeed

server/src/main/kotlin/fi/oph/kitu/oppijanumero/OppijanumeroService.kt

@@ -4,8 +4,9 @@ import com.fasterxml.jackson.databind.ObjectMapper
 import fi.oph.kitu.logging.addCondition
 import fi.oph.kitu.logging.withEvent
 import fi.oph.kitu.logging.withTryCatch
-import org.slf4j.LoggerFactory
+import org.slf4j.Logger
 import org.slf4j.spi.LoggingEventBuilder
+import org.springframework.beans.factory.annotation.Qualifier
 import org.springframework.beans.factory.annotation.Value
 import org.springframework.stereotype.Service
 import java.net.URI
@@ -20,9 +21,9 @@ interface OppijanumeroService {
 class OppijanumeroServiceImpl(
     private val casAuthenticatedService: CasAuthenticatedService,
     val objectMapper: ObjectMapper,
+    @Qualifier("oppijanumeroServiceLogger")
+    private val logger: Logger,
 ) : OppijanumeroService {
-    private val logger = LoggerFactory.getLogger(javaClass)
-
     @Value("\${kitu.oppijanumero.service.url}")
     lateinit var serviceUrl: String
 

server/src/main/kotlin/fi/oph/kitu/oppijanumero/OppijanumeroServiceLoggerConfig.kt

@@ -0,0 +1,12 @@
+package fi.oph.kitu.oppijanumero
+
+import org.slf4j.Logger
+import org.slf4j.LoggerFactory
+import org.springframework.context.annotation.Bean
+import org.springframework.context.annotation.Configuration
+
+@Configuration
+class OppijanumeroServiceLoggerConfig {
+    @Bean("oppijanumeroServiceLogger")
+    fun logger(): Logger = LoggerFactory.getLogger(OppijanumeroService::class.java)
+}

server/src/test/kotlin/fi/oph/kitu/logging/MockEvent.kt

@@ -13,6 +13,14 @@ class MockEvent : LoggingEventBuilder {
     val logs = mutableListOf<String?>()
     val defaultLogValue: String = "NULL"
 
+    /** Gets value from keyValues - list by the given key. */
+    inline fun <reified T> getValueOrNullByKey(key: String) =
+        keyValues
+            .filter { it.first == key }
+            .map { it.second }
+            .filterIsInstance<T>()
+            .firstOrNull()
+
     override fun setCause(p0: Throwable?): LoggingEventBuilder {
         causes.add(p0)
         return this