Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Upgrade dependencies for React 16 update #515

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Conversation

kylemh
Copy link
Member

@kylemh kylemh commented Oct 1, 2017

Description of changes

React 16 so we can take advantage of its many benefits 👍

Issue Resolved

Fixes #510

Note

To check this for errors, I recommend running rm -rf on your node_modules, checking out this branch, and then running running yarn install followed by yarn start

@sethbergman
Copy link
Member

It should be noted that there are a few breaking changes to iron out. I'm not sure if they are / will be prominent in our repo, but it's good to know. Also, there are some polyfills to fix the problems.

@kylemh
Copy link
Member Author

kylemh commented Oct 1, 2017

  • The first link we would've received warnings/errors for on compile time.
  • The second link is problematic only for IE11 and lower. Our IE11 support is already terrible (page breaks in IE11 on our work computers #153) so... I say onward!
  • The third link doesn't affect us at all since we do not have any tests.

I compiled our code-base with no issues and perused every static route. Feel free to attempt the same!

@sethbergman
Copy link
Member

I'll go ahead and test this so we can get it merged. 🚀

Copy link
Member

@sethbergman sethbergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the following commands after pulling down your branch.
rm yarn.lock yarn-error.log
rm -rf node_modules
yarn cache clean
yarn install
yarn start
I got the following errors during build time.

image

@sethbergman
Copy link
Member

Here is the error log from running yarn run build:

error-log.txt

Copy link
Member

@sethbergman sethbergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I shouldn't have run rm yarn.lock. I pulled down the one here and the build is now passing! 👍

@sethbergman
Copy link
Member

Ok I shouldn't have run rm yarn.lock. I pulled down the one here and the build is now passing! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants