Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hepa-uv): fix issue when turning on UV after re-seating the hepa/uv on the flex. #802

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Aug 20, 2024

Overview

When the door is closed, the reed switch is set, and the UV push button is pressed, the UV light turns on as expected.
However, if you then lift the back of the Hepa/UV and unset the reed switch, then set it back down setting the reed switch again. When you press the UV push button the safety relay pin will NOT be active even though the door is closed, and reed is set. The only way to activate the safety relay pin again is to open, and close the Flex door, and THEN press the UV push button again. This is by design per the hardware team as a way to make sure the user understands the intention when turning ON the UV light again.

Closes: RQA-2872

Changelog

  • Check safety relay is not set before attempting to change the UV light state.

Test Plan

  • Make sure that the UV light turns on when the door is closed, reed switch is set, and uv push button is pressed
  • Make sure that the UV light turns OFF and the push button LED is set to blue when the door is opened.
  • Make sure that the UV light turns OFF and the push button LED is set to blue when the reed switch is not set.
  • Make sure that after re-setting the reed switch that the UV light does not turn on and UV push button turns blue.
  • Make sure that after re-setting the reed switch that the UV light ONLY turns ON AFTER opening/closing the door.

@vegano1 vegano1 requested a review from CaseyBatten August 20, 2024 20:40
@vegano1 vegano1 requested a review from ahiuchingau August 20, 2024 20:53
@vegano1 vegano1 changed the base branch from main to chore_release-8.0.0 August 20, 2024 20:55
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit convoluted, but okay!

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Copy link

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to the relay activation case makes sense, and this seems fairly non-invasive.

@vegano1 vegano1 merged commit 668dcc8 into chore_release-8.0.0 Aug 22, 2024
27 of 30 checks passed
@vegano1 vegano1 deleted the RQA-2872-fix-button-led-issue branch August 22, 2024 17:45
y3rsh added a commit that referenced this pull request Sep 30, 2024
y3rsh added a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants