fix(sensors): Share sync line control bitmasks #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
requested changes
Aug 2, 2024
| [[nodiscard]] auto mask_satisfied() const -> bool { | ||
| if (set_sync_required_mask != | ||
| static_cast<uint8_t>(SensorIdBitMask::UNUSED)) { | ||
| printf("%x is required\n", set_sync_required_mask); |
There was a problem hiding this comment.
mmm don't like these even they compile out
|
|
||
| auto reset_sync(can::ids::SensorId sensor) -> void { | ||
| // force the bit for this sensor to 0 | ||
| sync_state_mask &= 0xFF ^ get_mask_from_id(sensor); |
There was a problem hiding this comment.
Suggested change
| sync_state_mask &= 0xFF ^ get_mask_from_id(sensor); | |
| sync_state_mask &= ~get_mask_from_id(sensor); |
?
There was a problem hiding this comment.
it's the more common way I've seen, anyway
ryanthecoder
force-pushed
the
share-sync-line-control-bitmasks
branch
from
69683e8 to
5d1fa27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had been mistaken about the sensor hardware being shared instances but I see now that they were not, so I broke out the bitmask communication between sensor tasks into another singleton that the sensor hardware tasks can share.
I also updated the tests so that when we test with multiple sensors they actually use two different hardware instances.