Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sensors): improvments to compile time defines for pressure move #760

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix(sensors): improvments to compile time defines for pressure move #760

merged 2 commits into from
Mar 19, 2024

Conversation

ryanthecoder
Copy link
Contributor

Some of the files weren't getting the compile flag at the right time, and then use a new per-pipette define to handle different static array sizes

sfoster1
sfoster1 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it might be nice to define it as 0 or 1 and that way it can always be defined but this works

@ryanthecoder ryanthecoder merged commit d4db0b2 into main Mar 19, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanthecoder @sfoster1