Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hepa-uv): add error code for door & reed state change during uv task #758

Conversation

ahiuchingau
Copy link
Contributor

This PR does two things:

  1. Add error code for door & reed state change so the hepa uv can notify the server when the uv task gets interrupted by the hardware states
  2. Only stops turns off the uv light if the hardware state changes if the uv task is running

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me,
thank you.

@vegano1 vegano1 self-requested a review March 18, 2024 18:35
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (750940a) to head (621608a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         101      101           
  Lines        4063     4063           
=======================================
  Hits         3384     3384           
  Misses        679      679           

@ahiuchingau ahiuchingau merged commit 1413581 into main Mar 19, 2024
31 checks passed
@ahiuchingau ahiuchingau deleted the PLAT-246-send-an-error-message-when-the-door-input-shuts-off-the-light branch March 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants