feat(protocol-designer): add load liquid commands #9923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #9923 +/- ##
==========================================
- Coverage 74.70% 74.69% -0.01%
==========================================
Files 2048 2054 +6
Lines 54034 54251 +217
Branches 5359 5421 +62
==========================================
+ Hits 40366 40525 +159
- Misses 12600 12644 +44
- Partials 1068 1082 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
approved these changes
Apr 11, 2022
| "4d23ffe0-b759-11ec-81e8-7fa12dc3e861": "opentrons/opentrons_96_filtertiprack_20ul/1" | ||
| }, | ||
| "dismissedWarnings": { "form": {}, "timeline": {} }, | ||
| "ingredients": { |
There was a problem hiding this comment.
this is quite the ingredients list 😆
| @@ -18,7 +18,7 @@ import type { | |||
|
|
|||
| export type CommandStatus = 'queued' | 'running' | 'succeeded' | 'failed' | |||
| export interface CommonCommandRunTimeInfo { | |||
| key: string | |||
| key?: string | |||
There was a problem hiding this comment.
why does this become optional?
There was a problem hiding this comment.
good question! two reasons
- in the v6 spec key is optional
- in order for
RunTimeCommands to extendCreateCommands, all properties must match if there are any that overlap. key was marked as optional inCreateCommand(which is correct), but required inRunTimeCommand, so TypeScript errors out.
| designerApplication?.data?.ingredLocations | ||
| )) { | ||
| Object.values(liquidsByWellName).forEach(volumeByLiquidId => { | ||
| if (liquidId in volumeByLiquidId) { |
There was a problem hiding this comment.
this is a lot of logic, I've seen in other files with a lot of logic have comments sprinkled in to help people understand what is going on easier 😄 (ex: see useModuleMatchResults)
There was a problem hiding this comment.
lol yes that is a good call, ill add some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds load liquid command to PD migrations, as well as the create file function which actually generates the final JSON file that users export.
closes #9702
Changelog
Review requests
Add a few different liquids to different labware in PD. Export the protocol, you should see load liquid commands generated in the commands list that conform to the
LoadLiquidCreateCommandinterface.Risk assessment
Low