Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(robot-server): bump to numpy in dev to v1.21.2 #9871

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Apr 4, 2022

Overview

This PR upgrades the Numpy dependency for the robot-server development environment to unblock development on M1 macs. It does not upgrade the numpy dependency in prod (yet).

Changelog

  • chore(robot-server): bump to numpy to v1.21.2

Review requests

  • Your local dev environment still works
  • Robot server in prod (with old numpy) still boots / runs

Risk assessment

No immediate risk. However, risk increases over time the longer we allow the development environment to drift from prod. We should get prod up to date as soon as we can. See Opentrons/buildroot#148 for that update.

@mcous mcous added chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Apr 4, 2022
@mcous mcous requested review from a team as code owners April 4, 2022 18:59
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #9871 (89450d1) into edge (c4e3976) will not change coverage.
The diff coverage is n/a.

❗ Current head 89450d1 differs from pull request most recent head 6e92e1c. Consider uploading reports for the commit 6e92e1c to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #9871   +/-   ##
=======================================
  Coverage   75.20%   75.20%           
=======================================
  Files        2005     2005           
  Lines       53156    53156           
  Branches     5148     5148           
=======================================
  Hits        39976    39976           
  Misses      12161    12161           
  Partials     1019     1019           
Flag Coverage Δ
notify-server 89.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mcous mcous marked this pull request as draft April 4, 2022 19:31
@mcous mcous changed the title chore(robot-server): bump to numpy v1.21.2 chore(robot-server): bump to numpy in dev to v1.21.2 Apr 4, 2022
@mcous mcous marked this pull request as ready for review April 4, 2022 21:00
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning to push that we do the buildroot upgrade right after our 5.1 release.

@mcous mcous merged commit 4dd9d70 into edge Apr 5, 2022
@mcous mcous deleted the upgrade-numpy branch April 5, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants