Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(python): ensure wheel/sdist builds are tested in CI #9848

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Mar 31, 2022

Overview

After I so rudely broke the opentrons_shared_data build with #9822, I figured it'd be smart to add wheel/sdist builds to regular CI for api + robot-server + shared-data to save us from ourselves in the future.

Changelog

  • ci(python): ensure wheel/sdist builds are tested in CI

Review requests

Check out the CI config file changes and inspect the CI runs of:

  • API test/lint/deploy
  • Robot server lint/test
  • shared-data test/lint/deploy

Risk assessment

Hopefully low! More CI checks for more safety in the future, especially when messing with setup.py et. al.

@mcous mcous added chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Mar 31, 2022
@mcous mcous requested review from a team as code owners March 31, 2022 20:08
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #9848 (52cc889) into edge (95f8e9c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #9848   +/-   ##
=======================================
  Coverage   75.29%   75.29%           
=======================================
  Files        2003     2003           
  Lines       53126    53126           
  Branches     5159     5159           
=======================================
  Hits        40001    40001           
  Misses      12111    12111           
  Partials     1014     1014           
Flag Coverage Δ
app 71.50% <ø> (ø)
notify-server 89.17% <ø> (ø)
protocol-designer 44.51% <ø> (ø)
shared-data 85.02% <ø> (ø)
step-generation 90.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@DerekMaggio DerekMaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for fixing all this so quickly :)

@mcous mcous merged commit f130ae5 into edge Mar 31, 2022
@mcous mcous deleted the ci_check-wheel-builds branch March 31, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants