Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): python: run coverage only in CI #9746

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Conversation

sfoster1
Copy link
Member

Python projects now only run coverage in CI, since in practice it's
unreadable as terminal output and just gets in the way of devs.

Python projects now only run coverage in CI, since in practice it's
unreadable as terminal output and just gets in the way of devs.
@sfoster1 sfoster1 requested review from a team as code owners March 22, 2022 14:27
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #9746 (f890113) into edge (15cf382) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #9746      +/-   ##
==========================================
+ Coverage   75.15%   75.16%   +0.01%     
==========================================
  Files        1956     1956              
  Lines       51697    51697              
  Branches     4948     4948              
==========================================
+ Hits        38853    38860       +7     
+ Misses      11905    11898       -7     
  Partials      939      939              
Flag Coverage Δ
api 85.06% <ø> (-0.02%) ⬇️
hardware 69.65% <ø> (+0.34%) ⬆️
notify-server 89.17% <ø> (ø)
robot-server 93.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hardware_control/emulation/module_server/server.py 75.55% <0.00%> (-4.45%) ⬇️
...are/hardware_control/motion_planning/move_utils.py 94.02% <0.00%> (+3.80%) ⬆️
...e/hardware_control/motion_planning/move_manager.py 93.61% <0.00%> (+4.25%) ⬆️

Copy link
Contributor

@amitlissack amitlissack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the coverage useful more than occasionally.

Can we not remove it please?

If it bothers you can you add a make target that runs tests with coverage?

@sfoster1
Copy link
Member Author

I find the coverage useful more than occasionally.

Can we not remove it please?

If it bothers you can you add a make target that runs tests with coverage?

will do

@sfoster1
Copy link
Member Author

@amitlissack would you prefer a separate target or an environment variable/makefile arg?

@amitlissack
Copy link
Contributor

@amitlissack would you prefer a separate target or an environment variable/makefile arg?

I have a 3% preference for separate target. Whatever is easier for you.

Copy link
Contributor

@amitlissack amitlissack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

notify-server/Makefile Outdated Show resolved Hide resolved
@sfoster1 sfoster1 merged commit a0b062f into edge Mar 22, 2022
@sfoster1 sfoster1 deleted the no-default-coverage branch March 22, 2022 21:34
b-cooper pushed a commit that referenced this pull request Mar 25, 2022
Python projects now only run coverage in CI, since in practice it's
unreadable as terminal output and just gets in the way of devs.

Co-authored-by: Mike Cousins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants