-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*): python: run coverage only in CI #9746
Conversation
Python projects now only run coverage in CI, since in practice it's unreadable as terminal output and just gets in the way of devs.
Codecov Report
@@ Coverage Diff @@
## edge #9746 +/- ##
==========================================
+ Coverage 75.15% 75.16% +0.01%
==========================================
Files 1956 1956
Lines 51697 51697
Branches 4948 4948
==========================================
+ Hits 38853 38860 +7
+ Misses 11905 11898 -7
Partials 939 939
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the coverage useful more than occasionally.
Can we not remove it please?
If it bothers you can you add a make target that runs tests with coverage?
will do |
@amitlissack would you prefer a separate target or an environment variable/makefile arg? |
I have a 3% preference for separate target. Whatever is easier for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Co-authored-by: Mike Cousins <[email protected]>
Python projects now only run coverage in CI, since in practice it's unreadable as terminal output and just gets in the way of devs. Co-authored-by: Mike Cousins <[email protected]>
Python projects now only run coverage in CI, since in practice it's
unreadable as terminal output and just gets in the way of devs.