Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(app): add selectors for devices pages #9611

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

brenthagen
Copy link
Contributor

Overview

backfill selectors for a variety of unified app devices pages; also adds an id prop to the toggle button interface

closes #9434

Changelog

  • Adds devices pages selectors

Review requests

confirm selectors are correct and toggle button changes make sense

Risk assessment

low

backfill selectors for a variety of unified app devices pages

closes #9434
@brenthagen brenthagen requested a review from a team as a code owner March 2, 2022 20:50
@brenthagen brenthagen removed the request for review from a team March 2, 2022 20:50
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #9611 (1845363) into edge (6aef991) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #9611   +/-   ##
=======================================
  Coverage   75.80%   75.80%           
=======================================
  Files        1920     1920           
  Lines       51585    51588    +3     
  Branches     4904     4905    +1     
=======================================
+ Hits        39104    39107    +3     
  Misses      11554    11554           
  Partials      927      927           
Flag Coverage Δ
app 73.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/organisms/Devices/DevicesEmptyState.tsx 100.00% <ø> (ø)
app/src/organisms/Devices/ModuleIcon.tsx 100.00% <ø> (ø)
app/src/organisms/Devices/PipettesAndModules.tsx 100.00% <ø> (ø)
app/src/organisms/Devices/RecentProtocolRuns.tsx 75.00% <ø> (ø)
app/src/organisms/Devices/RobotCard.tsx 50.00% <ø> (ø)
app/src/organisms/Devices/RobotOverview.tsx 75.00% <ø> (ø)
app/src/organisms/Devices/RobotStatusBanner.tsx 88.88% <ø> (ø)
app/src/pages/Devices/DevicesLanding/index.tsx 100.00% <ø> (ø)
app/src/atoms/ToggleBtn/index.tsx 100.00% <100.00%> (ø)
.../organisms/Devices/HeaterShakerWizard/KeyParts.tsx 66.66% <0.00%> (+66.66%) ⬆️

Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@reachojhaneha reachojhaneha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the selectors. LGTM and thank you

@brenthagen brenthagen merged commit 7d67da4 into edge Mar 2, 2022
@brenthagen brenthagen deleted the app_devices-pages-selectors branch March 2, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selectors for e2e tests - Unified App - Devices Page
3 participants