Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(windows): pin to windows-2019 #9537

Merged
merged 1 commit into from
Feb 22, 2022
Merged

ci(windows): pin to windows-2019 #9537

merged 1 commit into from
Feb 22, 2022

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Feb 22, 2022

Overview

GitHub Actions recently updated the windows-latest target to Windows 2022. This causes our builds to break.

This PR pins our Windows runners to the previous value of windows-2019. I've targetted this against the 5.0.1 branch to make sure that release goes out smoothly. We'll pick this up in edge in the sync-up PR following the release.

Changelog

  • ci(windows): pin to windows-2019

Review requests

  • CI is green

Risk assessment

N/A

@mcous mcous requested review from a team as code owners February 22, 2022 20:30
@mcous mcous requested review from jerader and removed request for a team February 22, 2022 20:30
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #9537 (136f48a) into hotfix_5.0.1 (459be85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           hotfix_5.0.1    #9537   +/-   ##
=============================================
  Coverage         75.54%   75.54%           
=============================================
  Files              1830     1830           
  Lines             49446    49446           
  Branches           4800     4800           
=============================================
  Hits              37356    37356           
  Misses            11201    11201           
  Partials            889      889           
Flag Coverage Δ
api 85.06% <ø> (ø)
app 73.29% <ø> (ø)
shared-data 81.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪟

@mcous mcous merged commit 156971c into hotfix_5.0.1 Feb 22, 2022
@mcous mcous deleted the ci_pin-windows branch February 22, 2022 21:04
@mcous mcous mentioned this pull request Feb 22, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants