Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tentative update app modal #908

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Add tentative update app modal #908

merged 2 commits into from
Feb 23, 2018

Conversation

Kadee80
Copy link
Contributor

@Kadee80 Kadee80 commented Feb 23, 2018

overview

Addresses #810 UI, adds the modal for app update but nothing more for now.

changelog

  • Add AppUpdateModal to AppSettings with dummy actions for now

review requests

Uncomment lines 5 and 11 in app/src/pages/AppSettings.js to view modal.

@Kadee80 Kadee80 added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review labels Feb 23, 2018
@Kadee80 Kadee80 requested review from mcous and IanLondon February 23, 2018 20:48
@codecov
Copy link

codecov bot commented Feb 23, 2018

Codecov Report

Merging #908 into v3a will increase coverage by 1.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              v3a     #908      +/-   ##
==========================================
+ Coverage   69.14%   70.19%   +1.04%     
==========================================
  Files         224      225       +1     
  Lines        6888     7335     +447     
  Branches      278      278              
==========================================
+ Hits         4763     5149     +386     
- Misses       2043     2104      +61     
  Partials       82       82
Impacted Files Coverage Δ
app/src/pages/AppSettings.js 0% <ø> (ø) ⬆️
app/src/components/AppSettings/index.js 0% <0%> (ø) ⬆️
app/src/components/AppSettings/AppInfoCard.js 0% <0%> (ø) ⬆️
app/src/components/AppSettings/AppUpdateModal.js 0% <0%> (ø)
app/src/http-api-client/health.js 92.85% <0%> (-1.27%) ⬇️
...pp/src/components/RobotSettings/InformationCard.js 0% <0%> (ø) ⬆️
...p/src/components/RobotSettings/ConnectivityCard.js 0% <0%> (ø) ⬆️
app/src/robot/selectors.js 85.06% <0%> (+1.12%) ⬆️
api/opentrons/instruments/pipette.py 97.75% <0%> (+1.13%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f676985...928a0b5. Read the comment docs.

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍 🐦


const HEADING = 'App Update Available'

const UPDATE_MESSAGE = 'We reccomend updating to the latest software version'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little typo! Should be "recommend"

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍶

@Kadee80 Kadee80 merged commit 5981fee into v3a Feb 23, 2018
@Kadee80 Kadee80 deleted the app_app-update-modal branch February 23, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants