-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tentative update app modal #908
Conversation
Codecov Report
@@ Coverage Diff @@
## v3a #908 +/- ##
==========================================
+ Coverage 69.14% 70.19% +1.04%
==========================================
Files 224 225 +1
Lines 6888 7335 +447
Branches 278 278
==========================================
+ Hits 4763 5149 +386
- Misses 2043 2104 +61
Partials 82 82
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐍 🐦
|
||
const HEADING = 'App Update Available' | ||
|
||
const UPDATE_MESSAGE = 'We reccomend updating to the latest software version' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little typo! Should be "recommend"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍶
overview
Addresses #810 UI, adds the modal for app update but nothing more for now.
changelog
AppUpdateModal
toAppSettings
with dummy actions for nowreview requests
Uncomment lines 5 and 11 in app/src/pages/AppSettings.js to view modal.