Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(robot-server): consolidate runs into a single Run model #8685

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Nov 9, 2021

Overview

As discussed in Slack, this is a simplification PR to remove the unnecessary distinction between a BasicRun and a ProtocolRun.

Changelog

  • Instead of two different types of runs, there is now one Run, which may optionally point to a protocolId if it's there to run a protocol

Review requests

Code changes make sense. This back-end PR requires a corresponding front-end PR

Risk assessment

Low

@mcous mcous added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label Nov 9, 2021
@mcous mcous requested a review from a team as a code owner November 9, 2021 18:29
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #8685 (bec64ca) into edge (4dfbc6f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #8685      +/-   ##
==========================================
- Coverage   75.23%   75.22%   -0.02%     
==========================================
  Files        1207     1207              
  Lines       37959    37934      -25     
  Branches     2792     2792              
==========================================
- Hits        28559    28535      -24     
+ Misses       8999     8998       -1     
  Partials      401      401              
Flag Coverage Δ
robot-server 93.39% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bot-server/robot_server/runs/router/base_router.py 96.07% <100.00%> (-0.04%) ⬇️
robot-server/robot_server/runs/run_models.py 100.00% <100.00%> (ø)
robot-server/robot_server/runs/run_store.py 100.00% <100.00%> (ø)
robot-server/robot_server/runs/run_view.py 100.00% <100.00%> (+3.44%) ⬆️

robot-server/robot_server/runs/run_models.py Outdated Show resolved Hide resolved
Comment on lines 68 to 71
commands: List[RunCommandSummary] = Field(
...,
description="Unique identifier of the protocol this run will execute.",
description="Protocol commands queued, running, or executed for the run.",
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea for this single commands list to contain both LPC commands and protocol commands?

If so, I guess it would take annotations to separate LPC commands from the actual protocol run log. Since we don't have that yet, is App+UI fine with not having that ability, for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think we're fine with that ability, because we will be using the protocol analysis commands as the scaffolding for the run log. We shouldn't need to use annotations to start the run log at the right command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants