Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(can): Hardware 32 bit move vals #8662

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Conversation

amitlissack
Copy link
Contributor

@amitlissack amitlissack commented Nov 8, 2021

Overview

Now that Can FD is working, we can use messages that are larger than 8 bytes.

Changelog

Review requests

Risk assessment

None

@amitlissack amitlissack requested a review from a team November 8, 2021 20:13
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #8662 (2aafb9c) into edge (bed6a2b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #8662   +/-   ##
=======================================
  Coverage   74.76%   74.76%           
=======================================
  Files        1731     1731           
  Lines       46511    46511           
  Branches     4666     4666           
=======================================
  Hits        34775    34775           
  Misses      10932    10932           
  Partials      804      804           
Flag Coverage Δ
hardware 83.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rons_hardware/drivers/can_bus/messages/payloads.py 100.00% <100.00%> (ø)
...e/opentrons_hardware/hardware_control/constants.py 100.00% <100.00%> (ø)
...ons_hardware/hardware_control/move_group_runner.py 94.64% <100.00%> (ø)

@amitlissack amitlissack marked this pull request as ready for review November 8, 2021 20:32
@amitlissack amitlissack requested a review from a team as a code owner November 8, 2021 20:32
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3️⃣2️⃣

@amitlissack amitlissack merged commit d616b17 into edge Nov 8, 2021
@amitlissack amitlissack deleted the hardware-32-bit-move-vals branch November 8, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants