Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(can): raise error when an error frame is detected. #8458

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

amitlissack
Copy link
Contributor

@amitlissack amitlissack commented Oct 5, 2021

Overview

We need to check for CAN bus error frames and raise an exception.

Changelog

Raise an exception when the message is marked as error frame.

Review requests

None

Risk assessment

None

@amitlissack amitlissack requested a review from a team October 5, 2021 13:44
@amitlissack amitlissack marked this pull request as ready for review October 5, 2021 13:46
@amitlissack amitlissack requested a review from a team as a code owner October 5, 2021 13:46
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #8458 (93202f9) into edge (8c008c4) will decrease coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #8458      +/-   ##
==========================================
- Coverage   74.25%   74.24%   -0.01%     
==========================================
  Files        1685     1686       +1     
  Lines       45383    45391       +8     
  Branches     4613     4613              
==========================================
+ Hits        33697    33702       +5     
- Misses      10893    10896       +3     
  Partials      793      793              
Flag Coverage Δ
hardware 61.86% <62.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dware/opentrons_hardware/drivers/can_bus/driver.py 75.00% <33.33%> (-2.78%) ⬇️
...dware/opentrons_hardware/drivers/can_bus/errors.py 80.00% <80.00%> (ø)

@amitlissack amitlissack merged commit c038929 into edge Oct 5, 2021
@amitlissack amitlissack deleted the hardware-error-frame branch October 5, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants