Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): add selectors to Metadata Card and Robot Calibration Step #8426

Merged
merged 5 commits into from
Oct 4, 2021

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Sep 29, 2021

fix #8336

Overview

Add selectors for Metadata Card and Robot Calibration Step

Changelog

Added selectors for all CTA's and Links in the Robot Calibration Step
Added selectors for all elements in the Metadata Card

Review requests

  • Robot Calibration Help Link to open Modal= DeckCalibration_robotCalibrationHelpLink
  • Robot Calibration Learn More Link within Modal = RobotCalModal_helpArticleLink
  • Robot Calibration Modal X Button = RobotCalModal_xButton
  • Robot Calibration Modal Close Button = RobotCalModal_closeButton
  • Attach Pipette CTA = PipetteCalibration_attachPipetteButton
  • Pipette Mismatch Help Link = PipetteCalibration_pipetteMismatchHelpLink
  • Calibrate Pipette CTA = PipetteCalibration_calibratePipetteButton
  • Calibrate TipRack CTA = TipRackCalibration_calibrateTipRackButton
  • Recalibrate TipRack Link = TipRackCalibration_recalibrateTipRackLink
  • Proceed to Labware/Module Setup = RobotCalStep_proceedButton
  • Protocol Organization/Author = MetadataCard_protocolOrganizationAuthor
  • Protocol Description = MetadataCard_protocolDescription
  • Protocol Last Updated = MetadataCard_protocolLastUpdated
  • Protocol Creation Method = MetadataCard_protocolCreationMethod
  • Protocol Estimated Run Time = MetadataCard_protocolEstRunTime
  • Setup for Run = RunSetupCard_setupForRun
  • Robot Calibration =RunSetupCard_robot_calibration_step
  • Calibration needed icon RunSetupCard_calibrationIcon
  • Calibration needed text = RunSetupCard_calibrationText
  • Deck Calibration = DeckCalibration_deckCalibrationTitle
  • LEFT MOUNT = PipetteCalibration_leftMountTitle
  • RIGHT MOUNT = PipetteCalibration_rightMountTitle
  • Required Pipettes = PipetteCalibration_requiredPipettesTitle
  • Required Tip Length Calibrations = TipRackCalibration_requiredTipLengthTitle

Risk assessment

Low

@smb2268 smb2268 requested a review from a team as a code owner September 29, 2021 14:55
@smb2268 smb2268 self-assigned this Sep 29, 2021
@smb2268 smb2268 requested review from shlokamin and removed request for a team September 29, 2021 14:55
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #8426 (5c3b546) into edge (7b3538f) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #8426      +/-   ##
==========================================
- Coverage   74.22%   74.19%   -0.03%     
==========================================
  Files        1647     1652       +5     
  Lines       44752    44886     +134     
  Branches     4578     4606      +28     
==========================================
+ Hits        33215    33301      +86     
- Misses      10753    10791      +38     
- Partials      784      794      +10     
Flag Coverage Δ
app 71.20% <33.33%> (-0.14%) ⬇️
components 48.50% <100.00%> (+0.75%) ⬆️
labware-library 50.22% <ø> (ø)
protocol-designer 44.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/atoms/structure/LabeledValue.tsx 100.00% <ø> (ø)
app/src/organisms/ProtocolSetup/MetadataCard.tsx 100.00% <ø> (ø)
...sms/ProtocolSetup/RunSetupCard/CollapsibleStep.tsx 100.00% <ø> (ø)
.../RunSetupCard/RobotCalibration/DeckCalibration.tsx 92.85% <0.00%> (ø)
...nSetupCard/RobotCalibration/PipetteCalibration.tsx 53.57% <ø> (ø)
...etupCard/RobotCalibration/TipLengthCalibration.tsx 38.18% <0.00%> (ø)
...tocolSetup/RunSetupCard/RobotCalibration/index.tsx 95.83% <ø> (ø)
...src/organisms/ProtocolSetup/RunSetupCard/index.tsx 85.71% <ø> (ø)
.../RunSetupCard/RobotCalibration/CalibrationItem.tsx 100.00% <100.00%> (ø)
components/src/icons/Icon.tsx 62.50% <100.00%> (ø)
... and 11 more

Copy link
Contributor

@reachojhaneha reachojhaneha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smb2268 smb2268 merged commit 37e2a44 into edge Oct 4, 2021
@smb2268 smb2268 deleted the app_robot-cal-selectors branch October 28, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App: adding identifiers for protocol upload revamp
2 participants