feat(labware-creator): use "tube" not "well" for x/y errors #8150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows LC to have dynamic error labels via getLabel. Closes #8142
IanLondon
requested review from
smb2268,
jerader,
a team and
shlokamin
and removed request for
a team
IanLondon
commented
Jul 22, 2021
| @@ -212,9 +212,9 @@ context('Reservoirs', () => { | |||
| cy.contains('close').click({ force: true }) | |||
|
|
|||
| // Brand info | |||
| cy.contains('Brand is required').should('exist') | |||
| cy.contains('Brand is a required field').should('exist') | |||
There was a problem hiding this comment.
IDK why before brand's error was "___ is required" and every other field's required error was "___ is a required field" 🤷
IanLondon
commented
Jul 22, 2021
|
|
||
| // sometimes fields have dynamic labels, and the "__ is a required field" error | ||
| // should use the dynamic label from getLabel. | ||
| if (error === MUST_BE_A_NUMBER_ERROR) { |
There was a problem hiding this comment.
I don't think we ever see the "must be a number" error anywhere, but just in case we do it in the future, I wanted it to follow the same pattern as the required field error.
IanLondon
commented
Jul 22, 2021
| @@ -82,7 +82,12 @@ export const CreateNewDefinition = (props: Props): JSX.Element | null => { | |||
| })} | |||
| > | |||
| <> | |||
| <FormAlerts touched={touched} errors={errors} fieldList={fieldList} /> | |||
| <FormAlerts | |||
There was a problem hiding this comment.
in the future we might want to avoid prop drilling and just use Formik context in FormAlerts. The only prop it really needs is fieldList.
IanLondon
commented
Jul 22, 2021
| @@ -459,6 +462,12 @@ export const getLabel = ( | |||
| if (name === 'wellShape') { | |||
| return `${capitalize(getLabwareName(values, false))} shape` | |||
| } | |||
| if (name === 'wellXDimension' && displayAsTube(values)) { | |||
There was a problem hiding this comment.
nicely, this change to getLabel now changes both the label and the text in the error alert
jerader
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #8142
Changelog
Review requests
Risk assessment
Medium, messes with LC errors' data flow