refactor(robot-server): split apart experimental sessions router #8057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #8057 +/- ##
==========================================
+ Coverage 85.88% 93.25% +7.37%
==========================================
Files 356 135 -221
Lines 21520 5263 -16257
==========================================
- Hits 18482 4908 -13574
+ Misses 3038 355 -2683
Continue to review full report at Codecov.
|
mcous
commented
Jul 6, 2021
mcous
force-pushed
the
robot-server_sessions-router-reorg
branch
from
2fd8771 to
1fd5d0b
Compare
mcous
added
robot-svcs
sanni-t
approved these changes
Jul 7, 2021
| ) | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) |
| spec=real_get_session, | ||
| ) | ||
| # TODO(mc, 2021-07-06): add signature support in decoy | ||
| get_session.__signature__ = inspect.signature( # type: ignore[attr-defined] |
There was a problem hiding this comment.
Is this required because decoy.create_decoy_func(spec=real_get_session) doesn't copy the type signatures of the spec?
There was a problem hiding this comment.
Yeah, filed a ticket for it mcous/decoy#29. Should be pretty straghtforward; decoy spies need to implement the __signature__ magic property
Co-authored-by: Sanniti Pimpley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is precursor work to #7921, split into its own PR to ease reviews. It is a pure reorganization PR; it does not affect functionality.
Changelog
This PR splits the previously monolithic
robot_server/sessions/router.pyinto three separate routers:robot_server/sessions/router/base_router.pyfor/sessionsroutesrobot_server/sessions/router/commands_router.pyfor/sessions/.../commandsroutesrobot_server/sessions/router/actions_router.pyfor/sessions/.../actionsroutesThe same corresponding change is made to the tests, with required changes to keep things green.
Review requests
/commandsrouter, I think the test changes make it clear that this split is beneficialRisk assessment
Very low. This entire router is feature flagged, and test coverage of the router was and remains high