-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(robot-server): exempt /logs and RPC from version header requirement #7927
Conversation
Codecov Report
@@ Coverage Diff @@
## release_4.4.0 #7927 +/- ##
==================================================
+ Coverage 80.70% 93.44% +12.74%
==================================================
Files 223 130 -93
Lines 16530 5083 -11447
==================================================
- Hits 13340 4750 -8590
+ Misses 3190 333 -2857 Continue to review full report at Codecov.
|
@@ -33,6 +34,7 @@ | |||
router.include_router( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't leave a comment in the right place because GitHub is dumb, but:
Can we leave a comment on the router.include_router(router=legacy_routes, ...)
above, to say that it's deliberately excluded from check_version_header
? (You've already done this for the sub-routers within legacy_routes
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That feels a little inaccurate to me, since many of the legacy_routes
are very much not excluded from the header check requirement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with the reproduction steps in #7924 that this fixes that bug.
Other than my optional nitpick above, LGTM. 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
Overview
This PR fixes an unreleased bug with robot logs downloads caused by #7632. It exempts certain endpoints (
/logs
included) to fix robot logs downloading.Closes #7924.
Changelog
Review requests
Risk assessment
Low. Revert of bad change