Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(labware-creator): add custom copy for tip rack volume section #7899

Merged
merged 4 commits into from
Jun 9, 2021

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Jun 7, 2021

Overview

Closes #7717 by adding dynamic Volume copy when tip racks are selected

Will need to add a test case

Changelog

  • Create util getLabwareName to get "well" or "tip" depending on labware type
  • Use util to display tip or well in volume section and error copy in formLevelValidation
  • Add test coverage for displaying tip copy

Review requests

  • Use "Volume" as title for all labware types
  • Change "well" to "tip" in description when tip rack is selected

Risk assessment

Low risk - will only impact dynamic copy in volume section and error messages

@smb2268 smb2268 self-assigned this Jun 7, 2021
@smb2268 smb2268 requested review from a team, Kadee80 and IanLondon and removed request for a team June 7, 2021 19:47
@smb2268 smb2268 force-pushed the lc_tiprack-volume-copy-7717 branch from 13c8e69 to c8e9194 Compare June 8, 2021 18:19
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (edge@547bc6d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c8e9194 differs from pull request most recent head 7368856. Consider uploading reports for the commit 7368856 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #7899   +/-   ##
=======================================
  Coverage        ?   83.71%           
=======================================
  Files           ?      353           
  Lines           ?    21611           
  Branches        ?        0           
=======================================
  Hits            ?    18091           
  Misses          ?     3520           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 547bc6d...7368856. Read the comment docs.

@smb2268 smb2268 force-pushed the lc_tiprack-volume-copy-7717 branch from c90440c to 7368856 Compare June 8, 2021 21:06
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪 LGTM! That util is gonna be very handy!

@smb2268 smb2268 merged commit d7bf804 into edge Jun 9, 2021
@smb2268 smb2268 deleted the lc_tiprack-volume-copy-7717 branch October 28, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LC: Custom tip racks volume section copy change
2 participants