feat(labware-creator): add dynamic footprint copy for tip racks #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smb2268
requested review from
a team,
Kadee80 and
shlokamin
and removed request for
a team
smb2268
force-pushed
the
lc_dynamic-footprint-copy-7715
branch
from
a2eab2f to
ed52b73
Compare
IanLondon
approved these changes
Jun 1, 2021
| }) | ||
|
|
||
| it('should render form alert when error is present', () => { | ||
| // formikConfig.initialValues.footprintXDimension = '130' |
Codecov Report
@@ Coverage Diff @@
## edge #7861 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 344 344
Lines 21494 21494
=======================================
Hits 17958 17958
Misses 3536 3536 Continue to review full report at Codecov.
|
shlokamin
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #7715 by adding dynamic footprint copy for tip racks
Changelog
react-testing-libraryReview requests
Risk assessment
Low risk - dynamic copy in labware creator only