docs(api): Update return_tip to drop_tip #7834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comments said that the two code snippet accomplished the same thing. The first (p300.transfer(100, plate['A1'], plate['B1'])) would drop the tip in the trash while the second
p300.pick_up_tip()
p300.aspirate(100, plate.wells('A1'))
p300.dispense(100, plate.wells('B1'))
p300.return_tip()
would return the tip to the tiprack. I changed return_tip in the second example to drop_tip so the two commands would be identical.
Codecov Report
@@ Coverage Diff @@
## edge #7834 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 336 336
Lines 21350 21350
=======================================
Hits 17824 17824
Misses 3526 3526 Continue to review full report at Codecov.
|
SyntaxColoring
approved these changes
May 25, 2021
amitlissack
changed the title
amitlissack
changed the title
amitlissack
changed the title
Laura-Danielle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments said that the two code snippet accomplished the same thing. The first (p300.transfer(100, plate['A1'], plate['B1'])) would drop the tip in the trash while the second:
p300.pick_up_tip()
p300.aspirate(100, plate.wells('A1'))
p300.dispense(100, plate.wells('B1'))
p300.return_tip()
would return the tip to the tiprack. I changed return_tip in the second example to drop_tip so the two commands would perform identical actions.
Overview
Changelog
Review requests
Risk assessment