feat(api): JSON protocol pipette loading support in Protocol Engine #7766
Conversation
amitlissack
added
api
amitlissack
requested review from
a team,
celsasser and
mcous
and removed request for
a team and
celsasser
Codecov Report
@@ Coverage Diff @@
## edge #7766 +/- ##
=======================================
Coverage 83.06% 83.06%
=======================================
Files 331 331
Lines 21405 21407 +2
=======================================
+ Hits 17780 17782 +2
Misses 3625 3625
Continue to review full report at Codecov.
|
| @@ -51,11 +51,13 @@ def load_pipette( | |||
| self, | |||
| pipette_name: PipetteName, | |||
| mount: MountType, | |||
| pipette_id: Optional[str], | |||
There was a problem hiding this comment.
Will this ever be needed in this client? I'd be down to leave it out (or default it to None if that feels better)
There was a problem hiding this comment.
Good point. I'll remove it.
| @@ -97,6 +108,7 @@ async def load_pipette( | |||
| except RuntimeError as e: | |||
| raise FailedToLoadPipetteError(str(e)) from e | |||
|
|
|||
| pipette_id = self._resources.id_generator.generate_id() | |||
| pipette_id = pipette_id if pipette_id else \ | |||
There was a problem hiding this comment.
Should we be pedantic about checking is not None vs "is falsey"?
| @@ -19,6 +22,11 @@ class LoadPipetteRequest(BaseModel): | |||
| ..., | |||
| description="The mount the pipette should be present on.", | |||
| ) | |||
| pipetteId: Optional[str] = Field( | |||
| ..., | |||
There was a problem hiding this comment.
Same question I think you posted in the labware PR, but should we default this to None?
Overview
JSON Protocols define IDs for the required pipettes. This PR provides a JSON protocol runner the ability to send commands to the ProtocolEngine to load a pipette with a specific id.
closes #7430
Changelog
LoadPipetteRequesthas optionalpipetteIdparameter. ThepipetteIdwill be used as the state store ID if specified otherwise a new ID will be generated.Review requests
Risk assessment
None