Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: tweak eslint config for Storybook #7708

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Apr 23, 2021

Overview

Slight tweak to the linting config of the storybook PR to allow linting of stories even though we haven't quite figured out how to integrate the stories into full typechecking.

Changelog

  • Unignore **/*.stories.tsx in eslint config
    • This has the important side-effect of also unignoring them for prettier
  • Create a tsconfg-eslint-json config, without project references, to typescript-eslint can do its thing

    If your existing configuration does not include all of the files you would like to lint, you can create a separate tsconfig.eslint.json

  • Override a few eslint rules that don't make sense in stories, e.g. import/no-default-export

Review requests

Does this make sense and look ok?

Risk assessment

N/A, to be merged into edge via #7549

@mcous mcous requested a review from b-cooper April 23, 2021 16:34
@mcous mcous requested review from a team as code owners April 23, 2021 16:34
@mcous mcous changed the title Components add storybook linting fixup: tweak eslint config for Storybook Apr 23, 2021
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@mcous mcous merged commit bcd2fdb into components_add-storybook Apr 27, 2021
@mcous mcous deleted the components_add-storybook-linting branch April 27, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants