fix(api): api location cache fix #7609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitlissack
added
api
amitlissack
requested review from
a team,
ahiuchingau and
mcous
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## edge #7609 +/- ##
=======================================
Coverage ? 82.30%
=======================================
Files ? 328
Lines ? 22069
Branches ? 0
=======================================
Hits ? 18164
Misses ? 3905
Partials ? 0 Continue to review full report at Codecov.
|
sfoster1
approved these changes
Apr 8, 2021
mcous
approved these changes
Apr 8, 2021
nusrat813
approved these changes
Apr 8, 2021
|
Unable to reproduce pipettes issue on my machine. I don't really think missing pipettes makes sense for this branch; this code doesn't get anywhere near |
amitlissack
force-pushed
the
api_location-cache-fix
branch
from
fe24ee1 to
06d8835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The location cache is used regardless of which pipette is moving. If left moves immediately after right, the left move's cached location will be used. This can cause jerky motion.
closes #7156
Changelog
Review requests
Test on a robot using example protocols in #7156
Risk assessment
High.