chore(build): specify virtual env ubuntu version #7475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #7475 +/- ##
=======================================
Coverage ? 77.08%
=======================================
Files ? 197
Lines ? 16105
Branches ? 0
=======================================
Hits ? 12415
Misses ? 3690
Partials ? 0 Continue to review full report at Codecov.
|
shlokamin
changed the title
IanLondon
approved these changes
Mar 11, 2021
IanLondon
reviewed
Mar 11, 2021
| @@ -109,6 +109,9 @@ dist-macos-latest: dist-osx | |||
| .PHONY: dist-ubuntu-latest | |||
| dist-ubuntu-latest: dist-linux | |||
|
|
|||
| .PHONY: dist-ubuntu-18.04 | |||
| dist-ubuntu-latest: dist-linux | |||
There was a problem hiding this comment.
not sure what's going on here, is this line supposed to be dist-ubuntu-18.04?
There was a problem hiding this comment.
they're aliases matching github actions OS names for easier calling in workflows, so i think it should just call dist-linux like dist-ubuntu-latestdoes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Seems as though the latest ubuntu version is causing aws deployment issues.
PD deploys aren't working right now, though the other aws deploys seem to be fine. I think this is cuz github is still in the migration process.
This PR specifies ubuntu versions to the previously used "latest" version which is
ubuntu-18.04. The other option is to addAWS_EC2_METADATA_DISABLEDas an env variable (see the issue above), but as @genehack mentioned in slack it's probably a good idea to specify versions so we don't wind up with more surprises.Changelog
Review requests
Make sure builds still work
Risk assessment
Med