Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(robot-server): ProtocolManager expects a ThreadManager and not a SynchronousAdapter. #7175

Merged
merged 2 commits into from
Jan 5, 2021
Merged

fix(robot-server): ProtocolManager expects a ThreadManager and not a SynchronousAdapter. #7175

merged 2 commits into from
Jan 5, 2021

Conversation

amitlissack
Copy link
Contributor

Overview

There was a mixup in the type of adapter sent to ProtocolRunner. It expects a ThreadManager but got a SynchronousAdapter.

Changelog

  • Add typing to ThreadManager.sync.
  • Fix mismatch.

Review requests

None

Risk assessment

None. This is in a feature behind a feature flag.

@amitlissack amitlissack added fix PR fixes a bug robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). robot server Affects the `robot-server` project labels Jan 5, 2021
@amitlissack amitlissack requested a review from a team January 5, 2021 13:58
@amitlissack amitlissack requested a review from a team as a code owner January 5, 2021 13:58
@amitlissack amitlissack requested review from SyntaxColoring and sanni-t and removed request for a team January 5, 2021 13:58
@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #7175 (bff04fa) into edge (85b3d6b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #7175   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files         265      265           
  Lines       19027    19028    +1     
=======================================
+ Hits        15027    15028    +1     
  Misses       4000     4000
Impacted Files Coverage Δ
...ssion_types/protocol/execution/command_executor.py 89.13% <ø> (ø)
opentrons/hardware_control/thread_manager.py 85.59% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b3d6b...bff04fa. Read the comment docs.

@amitlissack amitlissack added the api Affects the `api` project label Jan 5, 2021
sfoster1
sfoster1 approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, like the typing

@amitlissack amitlissack merged commit c0c9225 into edge Jan 5, 2021
@amitlissack amitlissack deleted the robot-server_protocol-adapter branch January 5, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanni-t sanni-t sanni-t approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

@SyntaxColoring SyntaxColoring Awaiting requested review from SyntaxColoring

Assignees
No one assigned
Labels
api Affects the `api` project fix PR fixes a bug robot server Affects the `robot-server` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitlissack @sfoster1 @sanni-t