Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): workaround set-env deprecation #7010

Merged

Conversation

sfoster1
Copy link
Member

Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/). The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking.

The workaround is to enable the old behavior and have a message that yells at you about it.

@sfoster1 sfoster1 requested a review from mcous November 16, 2020 22:08
@sfoster1 sfoster1 requested a review from a team as a code owner November 16, 2020 22:08
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #7010 (8935e01) into chore_release-4.0.0-beta.0 (c382681) will decrease coverage by 3.90%.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                       @@
##           chore_release-4.0.0-beta.0    #7010      +/-   ##
==============================================================
- Coverage                       73.23%   69.33%   -3.91%     
==============================================================
  Files                             263      147     -116     
  Lines                           21107    15722    -5385     
==============================================================
- Hits                            15458    10901    -4557     
+ Misses                           5649     4821     -828     
Impacted Files Coverage Δ
...er/robot_server/service/json_api/resource_links.py
update-server/otupdate/buildroot/config.py
notify-server/notify_server/clients/queue_entry.py
...rver/robot_server/service/session/configuration.py
...er/robot_server/service/legacy/routers/pipettes.py
.../robot_server/robot/calibration/check/user_flow.py
.../session/session_types/deck_calibration_session.py
...r/robot_server/robot/calibration/deck/dev_types.py
update-server/otupdate/buildroot/update.py
...bot-server/robot_server/service/json_api/errors.py
... and 106 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c382681...8935e01. Read the comment docs.

Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfoster1 sfoster1 merged commit 3db0fea into chore_release-4.0.0-beta.0 Nov 16, 2020
sfoster1 added a commit that referenced this pull request Nov 16, 2020
Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/). The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking.

The workaround is to enable the old behavior and have a message that yells at you about it.
sfoster1 added a commit that referenced this pull request Nov 16, 2020
Github recently disabled the ::set-env command in their protocol runners because it was insecure (https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/). The fix for this was to use environment file piping instead. Unfortunately, even if you're interacting with it through e.g. a node wrapper like in https://github.com/actions/core, this is what you're always doing, so core needed a bump to v1.2.6 in all its dependencies. This didn't happen in https://github.com/actions/github-script as of this writing (open pr: actions/github-script#91) and therefore our builds started breaking.

The workaround is to enable the old behavior and have a message that yells at you about it.
@mcous mcous deleted the chore_workaround-gh-actions-not-updated branch June 10, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants