Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): clear all sessions for robot when disconnected, disable cal buttons #6962

Merged

Conversation

b-cooper
Copy link
Contributor

Overview

In order to prevent sessions from sticking around in redux state after a robot has disconnected,
purge all sessions that belong to the disconnected robot from redux state. All buttons on the
pipette info tab should be disabled with a tooltip if not connected to the robot, just as the
buttons on the robot page are.

Changelog

  • add new client only sessions:CLEAR_ALL_SESSIONS action that purges the redux store of the sessions associated with the given robot
  • new epic listens for robot:DISCONNECT_RESPONSE or robot:UNEXPECTED_DISCONNECT and dispatches new sessions:CLEAR_ALL_SESSIONS with the connected robot
  • fix small unrelated jog controls layout inconsistency (1 liner) on the SaveZ component, the two controls should be justified center in the cal check

Review requests

  • start a cal check session and the disconnect from wifi/usb, you should see the disconnect modal appear behind the session modal, and then the session modal should disappear. Upon reconnecting to the robot, the session modal should reappear where you left off.
  • run cal check and make sure that the jog controls in the z checks are properly center justified

Risk assessment

low, this mostly shore's up edge cases, but is worth thoroughly testing

…sable cal flow buttons

In order to prevent sessions from sticking around in redux state after a robot has disconnected,
purge all sessions that belong to the disconnected robot from redux state. All buttons on the
pipette info tab should be disabled with a tooltip if not connected to the robot, just as the
buttons on the robot page are.
@b-cooper b-cooper requested a review from mcous November 10, 2020 20:42
@b-cooper b-cooper requested a review from a team as a code owner November 10, 2020 20:42
@b-cooper b-cooper requested review from a team and Laura-Danielle and removed request for a team November 10, 2020 20:43
@b-cooper b-cooper added app Affects the `app` project hmg hardware, motion, and geometry ready for review labels Nov 10, 2020
@b-cooper b-cooper added this to the HMG Sprint 22 milestone Nov 10, 2020
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test on my robot and app; looks good to me

@b-cooper b-cooper merged commit 2ce4cb8 into chore_release-4.0.0-beta.0 Nov 11, 2020
@b-cooper b-cooper deleted the app_delete-sessions-on-unreachable branch November 11, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project hmg hardware, motion, and geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants