Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): add more information on xy jog #6931

Merged
merged 2 commits into from
Nov 5, 2020
Merged

refactor(app): add more information on xy jog #6931

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8151f00
refactor(app): add more information on xy jog
sfoster1 Nov 5, 2020
137a1d5
I really need to set up a git hook for this
sfoster1 Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/src/components/CalibrationPanels/SaveZPoint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ const TO_USE_Z =
'button to use this z position for the rest of deck calibration'
const CALIBRATION_HEALTH_TO_DETERMINE =
'button to determine how this position compares to the previously saved z-axis calibration coordinate'
const ALLOW_HORIZONTAL_TEXT =
'Need to jog across the deck to align the pipette in slot 5?'
const ALLOW_HORIZONTAL_TEXT = 'Reveal XY jog controls to move across deck'
const ALLOW_XY_JOG_INSTRUCTIONS =
'If the pipette is over the embossed 5, on the ridge of the slot, or hard to see, reveal the jog controls to move the pipette across the deck.'

const contentsBySessionType: {
[SessionType]: {
Expand Down Expand Up @@ -180,6 +181,9 @@ export function SaveZPoint(props: CalibrationPanelProps): React.Node {
{THEN}
<b>{` '${buttonText}' `}</b>
{isHealthCheck ? CALIBRATION_HEALTH_TO_DETERMINE : TO_USE_Z}.
<br />
<br />
{ALLOW_XY_JOG_INSTRUCTIONS}
</Text>
<video
key={demoAsset}
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/CalibrationPanels/__tests__/SaveZPoint.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ describe('SaveZPoint', () => {
})
wrapper
.find(
'button[children="Need to jog across the deck to align the pipette in slot 5?"]'
'button[children="Reveal XY jog controls to move across deck"]'
)
.invoke('onClick')({ preventDefault: () => {} })
jogDirections.forEach(direction => {
Expand Down