Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): p1000_single_v2.2, p20_single_v2.2 #6922

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Nov 5, 2020

Adds data for new pipette models P1000 Single V2.2 and P20 Single V2.2.
These models are required by pipetting function changes.

Adds data for new pipette models P1000 Single V2.2 and P20 Single V2.2.
These models are required by pipetting function changes.
@sfoster1 sfoster1 added feature Ticket is a feature request / PR introduces a feature api Affects the `api` project labels Nov 5, 2020
@sfoster1 sfoster1 requested review from starno, XiaoLing-git, ChrisYarka and a team November 5, 2020 15:15
@sfoster1 sfoster1 requested a review from a team as a code owner November 5, 2020 15:15
@sfoster1 sfoster1 requested review from ahiuchingau and removed request for a team November 5, 2020 15:15
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #6922 into chore_release-4.0.0-beta.0 will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                       @@
##           chore_release-4.0.0-beta.0    #6922      +/-   ##
==============================================================
- Coverage                       73.26%   73.09%   -0.17%     
==============================================================
  Files                             263      244      -19     
  Lines                           21026    20069     -957     
==============================================================
- Hits                            15404    14669     -735     
+ Misses                           5622     5400     -222     
Impacted Files Coverage Δ
opentrons/tools/write_pipette_memory.py 33.96% <0.00%> (ø)
notify-server/notify_server/clients/subscriber.py
update-server/otupdate/buildroot/file_actions.py
update-server/otupdate/buildroot/update.py
update-server/otupdate/buildroot/__main__.py
notify-server/notify_server/network/connection.py
notify-server/notify_server/clients/publisher.py
update-server/otupdate/buildroot/constants.py
notify-server/notify_server/app_sub.py
update-server/otupdate/buildroot/control.py
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6441f25...b857fe6. Read the comment docs.

@sfoster1 sfoster1 requested a review from a team November 5, 2020 17:31
Copy link

@ChrisYarka ChrisYarka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfoster1 sfoster1 merged commit 14659b8 into chore_release-4.0.0-beta.0 Nov 6, 2020
@sfoster1 sfoster1 deleted the api_gen2-function-updates-4.0 branch November 6, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants