-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app, api): calibration check middleware #6781
Merged
Laura-Danielle
merged 28 commits into
chore_release-4.0.0-beta.0
from
refactor_calibration_check_middleware
Oct 22, 2020
Merged
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4e36799
Lay groundwork for robot server refactor
Laura-Danielle 3f6eacf
Lay the ground work for app refactor
Laura-Danielle 666e584
Modify functions to match new behavior
Laura-Danielle 73fe740
app: use shared panels
Laura-Danielle b6f00a9
Robot server - fix linter errors
Laura-Danielle cec65d0
App - fix lint errors
Laura-Danielle 2b66e4e
Fixup more linter errors and tests
Laura-Danielle ae9dbd7
app - change around types
Laura-Danielle 70beb37
Add additional check command, lint fixes
Laura-Danielle f2aafea
app - fix up session type called
Laura-Danielle 614b98f
app - more screen fixes
Laura-Danielle 71e705b
robot-server - change around some states
Laura-Danielle 46155d6
app - fixup flow errors
Laura-Danielle 302205a
Fixup: add return tip state and handle second pipette properly
Laura-Danielle 3afe558
app - remove analytics, fixup more screens
Laura-Danielle e012706
Remove intercom analytics
Laura-Danielle 13eebef
handled reading length from instruments when instr is null
ahiuchingau c192ed4
app - send correct command to server in return tip
Laura-Danielle 67e2cab
Add a new dummy transition
Laura-Danielle 4ddb985
fix register initial point buffer for comparingHeight
ahiuchingau 2936ada
read channels and max vol from pip config
ahiuchingau 0a74abb
Robot server fix up all tests except tavern
Laura-Danielle 0de1edf
Fixup: remaining tests and address comments on PR
Laura-Danielle 2a7c469
Fixup - js linter errors
Laura-Danielle 05f8926
Fixup: comparison states and safety buffer
Laura-Danielle f6aae2a
Fixup: ensure the correct comparisons are being made for each step
Laura-Danielle d958f33
Fixup - rebase error
Laura-Danielle 2ed0fde
Merge branch 'chore_release-4.0.0-beta.0' into refactor_calibration_c…
Laura-Danielle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the stuff in 190:196 only apply to
isHealthCheck === true
? if so consider moving it into the if block on 185:187. Also consider making this aconst
-binding using an anonymous function or a logical expression like a ternary, eg