-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): update pipette attach flow to include calibration #6760
Conversation
When attaching a pipette, if you do not currently have a pipette offset calibration stored for that combination of pipette serial number and mount, attach pipette flow will directly feed into the pipette offset calibration flow (which may also include tip length cal for the tip used in pipette offset cal) Closes #2130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problems:
- Styling nit: the continue button from leveling probably should be the same fixed-width as the confirm button, and there should be some space between the two.
We may also want to have the second button be a SecondaryBtn and say something like "Exit without calibrating"
- If you exit the offset calibration session early, it sends the command to move to "exited" but doesn't actually delete the session
- Probably want the spinner to render with "Homing {mount} pipette" when you enter offset calibration rather than "Moving {mount} pipette up"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also really should put the new buttons behind a feature flag.
Codecov Report
@@ Coverage Diff @@
## edge #6760 +/- ##
==========================================
- Coverage 89.11% 80.65% -8.47%
==========================================
Files 101 240 +139
Lines 4519 20641 +16122
==========================================
+ Hits 4027 16647 +12620
- Misses 492 3994 +3502
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the flows in attach pipette and in attach pipette with leveling, and the pipette info button, LGTM
Overview
When attaching a pipette, if you do not currently have a pipette offset calibration stored for that
combination of pipette serial number and mount, attach pipette flow will directly feed into the
pipette offset calibration flow (which may also include tip length cal for the tip used in pipette
offset cal)
Closes #2130
Changelog
useCalibratePipetteOffset
that manages the complexities of pipette offset calibration setup and flow. It returns a callback to start the flow and the component that contains the wizard if the flow has started. This flexibility will allow us to anchor the pipette offset calibration flow in the many embedded locations that it needs to exist, without having to duplicate the pretty gnarly session request management concerns.Review requests
-The standalone "CalibrateOffset" button on the Pipettes tab should function exactly as it has in the past, despite the fact that it is using the new hooks based "useCalibratePipetteOffset" implementation
Risk assessment
medium as this functionality is not being put behind a feature flag, considering it will be release along with everything else soon to have the
enableCalibrationOverhaul
gate removed.