refactor(robot-server): add time link to /health, refactor system/time links #6517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…system/time links Addresses #6501
sanni-t
requested review from
mcous and
amitlissack
and removed request for
a team
mcous
reviewed
Sep 10, 2020
| @@ -24,20 +22,10 @@ def _create_response(dt: datetime) \ | |||
| ), | |||
| resource_id="time" | |||
| ), | |||
| links=_get_valid_time_links(router) | |||
| links={'self': '/system/time'} | |||
There was a problem hiding this comment.
According to our chat this morning and #6526, should this be a ResourceLink instead?
links={'self': ResourceLink(href='/system/time'}}There was a problem hiding this comment.
From offline conversation, @amitlissack will be updating the time links to the new format as part of #6526
amitlissack
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR #6501 uses the time endpoints to check & update robot's system time. In the absence of a time endpoint, which is true for all versions < 3.21, the app would get a 404 for this endpoint. This PR adds a time link to the health endpoint so that the app can check for the presence of time endpoints and only then attempt to use them.
Changelog
Risk assessment
Low. Doesn't touch any critical components