fix(api): don't stomp other loggers in log config #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent robot-server PR deferred API loading until after the server is up, which is a great change but means that the API-side logging configuration now stomps on the robot server's logging configuration, so robot server messages are not logged. This commit removes the stomping and the robot server's logs should now be visible again.
sfoster1
requested review from
ahiuchingau,
a team,
mcous and
amitlissack
and removed request for
a team
amitlissack
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent robot-server PR deferred API loading until after the server is
up, which is a great change but means that the API-side logging
configuration now stomps on the robot server's logging configuration, so
robot server messages are not logged.
This commit removes the stomping and the robot server's logs should now
be visible again.
Testing
Push this and make sure you can see robot server logs