Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): lazy load air gap/delay FF from local storage #6252

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

shlokamin
Copy link
Member

Overview

This PR addresses the local storage getItem error we were getting when PD initially loads. The web worker was trying to fetch from local storage because one of the dependencies in its scope was attempting to hit local storage at module load. This also uncovered a test that was not updated, so I updated it to account for extra fields that needed to be added to pre saved step forms.

Changelog

  • lazy load air gap/delay FF from local storage

Review requests

Validate that there is no local storage error in the browser console when PD loads
Make sure the default airgap/delay args still show up in the presaved form when the FF is on

Risk assessment

Low

@shlokamin shlokamin requested review from Kadee80, IanLondon and a team July 31, 2020 15:32
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, file saves w/o fields when FF is off, w/ fields when FF is on, no console errors on fresh load after clearing site data

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@shlokamin shlokamin merged commit 414dc0b into edge Aug 3, 2020
@shlokamin shlokamin deleted the pd_lazy-load-default-fields branch August 3, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants