fix(api): set parent for in-slot offsets to empty #6211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We store calibration offsets by parent - including by slot. When an offset is stored for a slot, the parent key (which is used to determine the location of the calibration file) is saved as the labware hash. However, this is not how it should be expressed when loaded - the parent of a slot-relative offset is empty until and unless we start saving different calibration offsets for the same labware in different slots. Also, fill out the example fields for the labware calibration model in the robot server and restore an early return in get labware calibrations if there are no calibrations to return.
sfoster1
added
api
b-cooper
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store calibration offsets by parent - including by slot. When an
offset is stored for a slot, the parent key (which is used to determine
the location of the calibration file) is saved as the labware hash.
However, this is not how it should be expressed when loaded - the parent
of a slot-relative offset is empty until and unless we start saving
different calibration offsets for the same labware in different slots.
Also, fill out the example fields for the labware calibration model in
the robot server and restore an early return in get labware calibrations
if there are no calibrations to return.
This also is required to support #6100