refactor(discovery-client): add new mDNS browser wrapper #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
ready for review
robot-svcs
mcous
requested review from
amitlissack,
sanni-t and
b-cooper
and removed request for
a team
mcous
force-pushed
the
dc_refactor-initialize-state
branch
from
b851ab8 to
8d3c8ea
Compare
mcous
force-pushed
the
dc_refactor-mdns-wrapper
branch
from
9ad39d0 to
d0204e5
Compare
amitlissack
approved these changes
Jul 21, 2020
sanni-t
approved these changes
Jul 21, 2020
mcous
force-pushed
the
dc_refactor-mdns-wrapper
branch
from
d0204e5 to
396b99d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new mDNS browser wrapper to the Discovery Client to create a unified facade around the mDNS browser provided by mdns-js. Mostly, this PR serves to move setup and teardown logic that currently exists in the
DiscoveryClientclass and put it into a testable module that can bestarted andstopped like theHealthPollerBlocked by #6153 and will require rebase
Changelog
Review requests
This is the last PR before the PR that actually wires things up and can be tested on actual robots. For now, without the wireup:
Risk assessment
N/A