-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): add delay form fields #6085
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #6085 +/- ##
=======================================
Coverage ? 79.22%
=======================================
Files ? 187
Lines ? 18127
Branches ? 0
=======================================
Hits ? 14362
Misses ? 3765
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏑
Overview
This PR closes #6006 by adding delay form fields to transfer steps
Changelog
Review requests
Code review
When FF on, delay form field should show up in transfer step under advanced settings (both aspirate and dispense).
When FF on, delay form field should have tool tips matching these
When FF off, delay form field should NOT show up in advanced settings
Risk assessment
Low, behind FF