Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): add delay form fields #6085

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Jul 8, 2020

Overview

This PR closes #6006 by adding delay form fields to transfer steps

Changelog

  • Add delay form fields to transfer steps

Review requests

  • Code review

  • When FF on, delay form field should show up in transfer step under advanced settings (both aspirate and dispense).

  • When FF on, delay form field should have tool tips matching these

  • When FF off, delay form field should NOT show up in advanced settings

Risk assessment

Low, behind FF

@shlokamin shlokamin marked this pull request as ready for review July 8, 2020 15:40
@shlokamin shlokamin requested review from a team, Kadee80 and IanLondon and removed request for a team July 8, 2020 15:40
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (edge@7f935f3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #6085   +/-   ##
=======================================
  Coverage        ?   79.22%           
=======================================
  Files           ?      187           
  Lines           ?    18127           
  Branches        ?        0           
=======================================
  Hits            ?    14362           
  Misses          ?     3765           
  Partials        ?        0           
Impacted Files Coverage Δ
opentrons/drivers/rpi_drivers/gpio_simulator.py 76.54% <0.00%> (ø)
opentrons/api/dev_types.py 0.00% <0.00%> (ø)
...obot-server/robot_server/service/session/errors.py 100.00% <0.00%> (ø)
...ce/session/session_types/tip_length_calibration.py 68.00% <0.00%> (ø)
...rver/robot_server/service/session/configuration.py 91.66% <0.00%> (ø)
opentrons/config/__init__.py 57.43% <0.00%> (ø)
opentrons/data_storage/old_container_loading.py 89.04% <0.00%> (ø)
opentrons/drivers/rpi_drivers/dev_types.py 0.00% <0.00%> (ø)
opentrons/protocol_api/execute_v4.py 96.18% <0.00%> (ø)
...obot-server/robot_server/service/legacy/rpc/rpc.py 91.16% <0.00%> (ø)
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f935f3...63ad139. Read the comment docs.

Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏑

@shlokamin shlokamin merged commit eeb56cc into edge Jul 13, 2020
@shlokamin shlokamin deleted the pd_delay-form-fields branch July 13, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: PD Form fields- Delay
3 participants