Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol-designer): change pipette select to use data-test instead of data-id #6050

Merged
merged 1 commit into from
Jul 2, 2020
Merged

refactor(protocol-designer): change pipette select to use data-test instead of data-id #6050

merged 1 commit into from
Jul 2, 2020

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Jul 2, 2020 •
edited
Loading

Overview

This PR changes the PipetteSelect component in PD to use data-test instead of data-id to be consistent with the rest of the monorepo.

Changelog

  • Change PipetteSelect component in PD to use data-test instead of data-id
  • Update cypress test to use data-test instead of data-id

Risk assessment

Low

@shlokamin shlokamin requested review from Kadee80 and IanLondon July 2, 2020 15:26
@shlokamin shlokamin requested a review from a team as a code owner July 2, 2020 15:26
@shlokamin shlokamin requested a review from a team July 2, 2020 15:26
Kadee80
Kadee80 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧊

IanLondon
IanLondon approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@IanLondon IanLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

@shlokamin shlokamin merged commit cd481a7 into edge Jul 2, 2020
@shlokamin shlokamin deleted the pd_pipette-select-use-data-test branch July 2, 2020 16:23
@IanLondon IanLondon mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanLondon IanLondon IanLondon approved these changes

@Kadee80 Kadee80 Kadee80 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shlokamin @Kadee80 @IanLondon