feat(components): add primitive btns and fix useHover on disabled buttons #5972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
added
feature
IanLondon
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
🆗
-
protocol-designer/src/components/StepCreationButton.js -
protocol-designer/src/components/modals/EditModulesModal/index.js -
protocol-designer/src/components/modules/ModuleRow.js -
protocol-designer/src/components/StepEditForm/fields/ProfileItemRows.js -
protocol-designer/src/components/StepEditForm/fields/ChangeTipField/ChangeTip.js -
protocol-designer/src/components/StepEditForm/fields/TipPositionField/index.js -
protocol-designer/src/components/StepEditForm/fields/WellOrderField/index.js -
protocol-designer/src/components/steplist/AspirateDispenseHeader.js -
protocol-designer/src/components/steplist/MixHeader.js -
protocol-designer/src/components/steplist/ModuleStepItems.js -
protocol-designer/src/components/steplist/SubstepRow.js
b-cooper
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
A very common pattern that comes up when using our buttons is: "display a tooltip when this button is disabled". There are two problems that prevent us from doing this easily with out current button components:
pointer-events: noneto the button node, preventing enter and leave events<button>is disabled, React will not triggermouseleaveevents (normouseenterevents, starting at React v16.13), even ifpointer-eventsaren't touched and sometimes even if the handlers are attached to the button's parentThis PR tackles both of these issues so that we can easily display tooltips on disabled buttons:
primitivesthat don't come with any of our existing button baggage:<Btn>-<button>with CSS reset and defaulttype="button"<PrimaryBtn>-<Btn>styled to look like a "Primary Button" from the Zeplin components guide<SecondaryBtn>-<Btn>styled to look like a "Secondary Button" from the Zeplin components guide<LightSecondaryBtn>-<Btn>styled to look like a "Light Secondary Button" from the Zeplin components guide<TertiaryBtn>-<Btn>styled to look like a "Tertiary Button" from the Zeplin components guideuseHoverhook from MouseEvents to PointerEventschangelog
<OutlineButton>components to<SecondaryBtn>components to demonstrate usage and tooltipsreview requests
Components where
useHoverTooltipis used and smoke testing is neededapp/src/components/CheckCalibration/EndOfStepComparisons.jsapp/src/components/CheckCalibration/PipetteComparisons.jsapp/src/components/RobotSettings/CheckCalibrationControl.jsprotocol-designer/src/components/StepCreationButton.jsprotocol-designer/src/components/modals/EditModulesModal/index.jsprotocol-designer/src/components/modules/ModuleRow.jsprotocol-designer/src/components/StepEditForm/fields/ProfileItemRows.jsprotocol-designer/src/components/StepEditForm/fields/ChangeTipField/ChangeTip.jsprotocol-designer/src/components/StepEditForm/fields/TipPositionField/index.jsprotocol-designer/src/components/StepEditForm/fields/WellOrderField/index.jsprotocol-designer/src/components/steplist/AspirateDispenseHeader.jsprotocol-designer/src/components/steplist/MixHeader.jsprotocol-designer/src/components/steplist/ModuleStepItems.jsprotocol-designer/src/components/steplist/SubstepRow.jsrisk assessment
Button are important and this changes the handlers used for all existing usages of
useHoverTooltip, so this is medium risk. The following mitigation steps were taken:<Button>components