Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(labware-library): use slot 2 instead of 3 in LC test protocol #5950

Merged
merged 1 commit into from
Jun 18, 2020
Merged

feat(labware-library): use slot 2 instead of 3 in LC test protocol #5950

merged 1 commit into from
Jun 18, 2020

Conversation

IanLondon
Copy link
Contributor

overview

Closes #5019

changelog

review requests

  • Save zip from LC, unzip and run the test protocol. Labware should be in slot 2 instead of 3, protocol should run (if you don't have a robot, you can test that it uploads, or just visually inspect the .py file)

risk assessment

low, LC only

@IanLondon IanLondon requested review from Kadee80, shlokamin and a team June 17, 2020 20:37
@Kadee80 Kadee80 modified the milestone: SPDDRS Sprint 11 Jun 18, 2020
Kadee80
Kadee80 approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on the 🤖

@IanLondon IanLondon merged commit fbd1506 into edge Jun 18, 2020
@mcous mcous deleted the lc_use-slot-2-not-3 branch October 26, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kadee80 Kadee80 Kadee80 approved these changes

@shlokamin shlokamin Awaiting requested review from shlokamin

Assignees
No one assigned
Labels
labware creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LC Test Protocol: Labware in Slot 2
2 participants
@IanLondon @Kadee80