Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol-designer): add TC announcement modal #5898

Merged
merged 1 commit into from
Jun 12, 2020
Merged

feat(protocol-designer): add TC announcement modal #5898

merged 1 commit into from
Jun 12, 2020

Conversation

IanLondon
Copy link
Contributor

@IanLondon IanLondon commented Jun 12, 2020 •
edited
Loading

overview

Closes #5887

changelog

review requests

image

  • Should match design above -- EXCEPT, it should be 3.18 not 3.17
  • If you've already seen the old modal, you should still see this new modal when PD starts
  • If you've never seen the previous modal, you shouldn't be shown that one. Just this new one

risk assessment

low, PD only

@IanLondon IanLondon added WIP protocol designer Affects the `protocol-designer` project design labels Jun 12, 2020
@IanLondon IanLondon requested review from a team, Kadee80 and shlokamin and removed request for a team June 12, 2020 13:56
shlokamin
shlokamin approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modals 4 days

@Kadee80
Copy link
Contributor

Kadee80 commented Jun 12, 2020

Looking at the screen shot - do we need it to say 3.18?

Kadee80
Kadee80 approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎃

@IanLondon IanLondon merged commit e5894c5 into edge Jun 12, 2020
@IanLondon IanLondon mentioned this pull request Jul 14, 2020
Merged
@mcous mcous deleted the pd_tc-announcement-modal-5887 branch October 26, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlokamin shlokamin shlokamin approved these changes

@Kadee80 Kadee80 Kadee80 approved these changes

Assignees
No one assigned
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PD: Update announcement modal for Thermocycler (w new API version)
3 participants
@IanLondon @Kadee80 @shlokamin