Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol-designer): replace v4 protocol export hint #5897

Merged
merged 1 commit into from
Jun 12, 2020
Merged

feat(protocol-designer): replace v4 protocol export hint #5897

merged 1 commit into from
Jun 12, 2020

Conversation

IanLondon
Copy link
Contributor

overview

Closes #5888

changelog

review requests

  • With fresh browser state, upon exporting a protocol with modules you should see the 3.18 modal
  • If you dismiss the 3.17 modal with "Don't show me again", upon exporting a protocol with modules you should see the 3.18 modal

risk assessment

low, PD-only

@IanLondon IanLondon added ready for review protocol designer Affects the `protocol-designer` project labels Jun 12, 2020
@IanLondon IanLondon requested review from Kadee80, shlokamin and a team June 12, 2020 13:14
Kadee80
Kadee80 approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧯

shlokamin
shlokamin approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@IanLondon IanLondon merged commit 179f638 into edge Jun 12, 2020
@IanLondon IanLondon mentioned this pull request Jul 14, 2020
Merged
@mcous mcous deleted the pd_new-export-hint-5888 branch October 26, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlokamin shlokamin shlokamin approved these changes

@Kadee80 Kadee80 Kadee80 approved these changes

Assignees
No one assigned
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PD: exporting v4 protocol modal hint should say version 3.18
3 participants
@IanLondon @Kadee80 @shlokamin