feat(protocol-designer): finish form-level errors for dynamic fields #5818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Show form-level errors for steps that are inside a cycle (not just top-level steps) * Disable save when form-level errors are present
IanLondon
added
protocol designer
IanLondon
requested review from
Kadee80,
shlokamin and
a team
and removed request for
a team
IanLondon
commented
Jun 4, 2020
| @@ -432,7 +432,10 @@ const _dynamicFieldFormErrors = ( | |||
| export const _hasFieldLevelErrors = (hydratedForm: FormData): boolean => { | |||
| for (const fieldName in hydratedForm) { | |||
| const value = hydratedForm[fieldName] | |||
| if (fieldName === 'profileItemsById') { | |||
| if ( | |||
| hydratedForm.stepType === 'thermocycler' && | |||
There was a problem hiding this comment.
after re-reading this a few times I prefer it to be explicit: this is only for thermocycler forms, no other forms
shlokamin
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Closes #5814
changelog
review requests
NOTE: since the errors are not associated with a particular row, when any field of a given name is pristine, all will be treated as pristine. So adding a new step will hide any previously visible errors.
(There's just one error, if you don't have a > 0 mins + seconds)
risk assessment
low, PD-only and under a FF