Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer): Add scroll to top on export modal display #5744

Merged
merged 1 commit into from
May 29, 2020
Merged

fix(protocol-designer): Add scroll to top on export modal display #5744

merged 1 commit into from
May 29, 2020

Conversation

Kadee80
Copy link
Contributor

@Kadee80 Kadee80 commented May 27, 2020

overview

closes #5422 by adding a scrollTo Top function on export file button click.

changelog

  • fix(protocol-designer): Add scroll to top on export modal display

review requests

scroll to top should work on:

  • protocol has no steps modal
  • unused pipettes or modules modal
  • v4 export modal

risk assessment

Low. PD bug fix.

@Kadee80 Kadee80 added fix PR fixes a bug protocol designer Affects the `protocol-designer` project 🕷️ SPDDRS labels May 27, 2020
@Kadee80 Kadee80 requested review from shlokamin, IanLondon and a team May 27, 2020 16:32
shlokamin
shlokamin approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on

  • protocol has no steps modal
  • unused pipettes or modules modal
  • v4 export modal

@dozercodes dozercodes self-requested a review May 28, 2020 15:48
dozercodes
dozercodes approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@dozercodes dozercodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@Kadee80 Kadee80 merged commit f797cdc into edge May 29, 2020
@Kadee80 Kadee80 deleted the pd_export-modal-scroll-fix branch May 29, 2020 15:06
@IanLondon IanLondon mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlokamin shlokamin shlokamin approved these changes

@dozercodes dozercodes dozercodes approved these changes

@IanLondon IanLondon Awaiting requested review from IanLondon

Assignees
No one assigned
Labels
fix PR fixes a bug protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Modals that appear on Export don't scroll File Details window to top
3 participants
@Kadee80 @dozercodes @shlokamin