Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): collect pipette and module load analytics from protocol runs #5675

Merged
merged 1 commit into from
May 14, 2020

Conversation

mcous
Copy link
Contributor

@mcous mcous commented May 13, 2020

overview

This PR attaches pipette and module names to the existing protocol analytics event data

Closes #5540

changelog

  • feat(app): collect pipette and module load analytics from protocol runs

review requests

  • Code and tests look good

risk assessment

Low. Small, unit-tested addition to existing data collection selector

@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review labels May 13, 2020
@mcous mcous requested a review from a team as a code owner May 13, 2020 21:34
@mcous mcous requested review from IanLondon, a team, amitlissack and sanni-t and removed request for a team May 13, 2020 21:34
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #5675 into edge will increase coverage by 1.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #5675      +/-   ##
==========================================
+ Coverage   65.13%   66.68%   +1.55%     
==========================================
  Files        1116     1161      +45     
  Lines       30965    32591    +1626     
==========================================
+ Hits        20168    21734    +1566     
- Misses      10797    10857      +60     
Impacted Files Coverage Δ
app/src/analytics/selectors.js 34.78% <100.00%> (+6.21%) ⬆️
app/src/epic.js 0.00% <0.00%> (ø)
app/src/reducer.js 0.00% <0.00%> (ø)
...t-server/robot_server/service/models/networking.py 100.00% <0.00%> (ø)
robot-server/robot_server/service/routers/rpc.py 100.00% <0.00%> (ø)
app/src/sessions/epic/createSessionEpic.js 100.00% <0.00%> (ø)
robot-server/robot_server/service/logging.py 100.00% <0.00%> (ø)
robot-server/robot_server/service/models/health.py 100.00% <0.00%> (ø)
...bot-server/robot_server/service/models/pipettes.py 100.00% <0.00%> (ø)
app/src/sessions/reducer.js 92.85% <0.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba54e4...b5a5b49. Read the comment docs.

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧻

@mcous mcous merged commit 11feca3 into edge May 14, 2020
@mcous mcous deleted the app_pipette-and-modules-analytics branch May 14, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics: Protocol Properties
2 participants