-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app): add alert to SystemInfoCard if u2e driver outdated #5638
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #5638 +/- ##
==========================================
- Coverage 65.02% 64.95% -0.07%
==========================================
Files 1098 1101 +3
Lines 30687 30810 +123
==========================================
+ Hits 19953 20012 +59
- Misses 10734 10798 +64
Continue to review full report at Codecov.
|
e8fb7e2
to
1da668f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dispatched the fake event w Redux DevTools and got the warning
code looks good as far as I can tell. Link is nice.
overview
Blocked by #5637. This PR will be re-targeted to edge once it's mergedPR is ready for reviewThis PR adds a warning to the SystemInfoCard if the U2E driver is out of date. Closes #5491. See ticket for acceptance criteria.
changelog
review requests
enableSystemInfo
feature flag should be enabledIf Windows, plug in a U2E adapter with your driver out of date
If not Windows, dispatch a fake USB device added action
System Information card in More > Network and System page should show warning
Warning should have button to Realtek's download page
risk assessment
Low. Additions are unit tested and behind a feature flag