Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(robot-server): upgrade fastapi to 0.54.1 #5439

Merged
merged 4 commits into from
Apr 20, 2020
Merged

chore(robot-server): upgrade fastapi to 0.54.1 #5439

merged 4 commits into from
Apr 20, 2020

Conversation

amitlissack
Copy link
Contributor

overview

  • Upgrade package version
  • Identify dependencies accurately in Config.in

changelog

Remove workarounds related to old bugs in fastapi.

review requests

I've tested on my rPI

risk assessment

None

@amitlissack amitlissack added robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). robot server Affects the `robot-server` project labels Apr 16, 2020
@amitlissack amitlissack requested a review from a team April 16, 2020 17:11
@amitlissack amitlissack requested review from a team as code owners April 16, 2020 17:11
@amitlissack amitlissack requested review from mcous and sanni-t and removed request for a team April 16, 2020 17:11
@codecov
Copy link

codecov bot commented Apr 16, 2020 •
edited
Loading

Codecov Report

Merging #5439 into edge will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #5439      +/-   ##
==========================================
- Coverage   65.88%   65.83%   -0.05%     
==========================================
  Files        1080     1081       +1     
  Lines       30666    30689      +23     
==========================================
  Hits        20204    20204              
- Misses      10462    10485      +23
Impacted Files Coverage Δ
...ot-server/robot_server/service/routers/settings.py 100.00% <100.00%> (ø)
labware-library/src/labware-creator/index.js 0.00% <0.00%> (ø)
shared-data/js/cypressUtils.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4d416...5a09837. Read the comment docs.

sfoster1
sfoster1 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcous
mcous approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@amitlissack amitlissack merged commit 0db633b into edge Apr 20, 2020
@amitlissack amitlissack deleted the robot_server_packages branch April 20, 2020 21:09
IanLondon pushed a commit that referenced this pull request Apr 22, 2020
@IanLondon
chore(robot-server): upgrade fastapi to 0.54.1 (#5439)
16b9a75 
* updgrade fastapi to 0.54.1

* remove workarounds to deal with bugs in fastapi

* lint errors

* select BR2_PACKAGE_PYTHON_DOTENV package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

@mcous mcous mcous approved these changes

@sanni-t sanni-t Awaiting requested review from sanni-t

Assignees
No one assigned
Labels
robot server Affects the `robot-server` project robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitlissack @mcous @sfoster1